Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplyEventException can leak event data to logs #2849

Closed
elexisvenator opened this issue Dec 7, 2023 · 1 comment
Closed

ApplyEventException can leak event data to logs #2849

elexisvenator opened this issue Dec 7, 2023 · 1 comment
Milestone
7.0.0

Comments

@elexisvenator
Copy link
Contributor

This exception will leak the contents of your events to logs if you are using records for your events:

public ApplyEventException(IEvent @event, Exception innerException): base(
        $"Failure to apply event #{@event.Sequence} ({@event.Data}.)", innerException)

Its a unfortunate side effect of records :(
erdtsieck added a commit to erdtsieck/marten that referenced this issue Dec 10, 2023
@erdtsieck
JasperFx#2849 ApplyEventException can leak event data to logs
b0f642e
@jeremydmiller jeremydmiller added this to the 7.0.0 milestone Dec 12, 2023
jeremydmiller pushed a commit that referenced this issue Dec 12, 2023
@erdtsieck @jeremydmiller
#2849 ApplyEventException can leak event data to logs
71d0eb9
@jeremydmiller
Copy link
Member

Closed by #2854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@jeremydmiller @elexisvenator