Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IdentitySession and Lightweight session the default one #2463

Merged
merged 7 commits into from
Feb 13, 2023
Merged

Added IdentitySession and Lightweight session the default one #2463

merged 7 commits into from
Feb 13, 2023

Conversation

oskardudycz
Copy link
Collaborator

@oskardudycz oskardudycz commented Jan 18, 2023 •
edited

  • Added IdentitySession method to DocumentStore,
  • Added async overloads to all sessions initialisation,
  • Added logger to default session factory to give warning about not using Lightweight session,
  • Updated tests accordingly to not use generic OpenSession method.

Fixes #2239

@oskardudycz oskardudycz marked this pull request as draft January 18, 2023 12:06
@oskardudycz oskardudycz changed the title Added IdentitySession and Lightweight session the default one WIP: Added IdentitySession and Lightweight session the default one Jan 18, 2023
@oskardudycz oskardudycz self-assigned this Jan 18, 2023
@mysticmind
Copy link
Member

This PR resolves #2239

@oskardudycz oskardudycz force-pushed the lightweight_session_default branch 5 times, most recently from 50b8792 to 6a63b69 Compare February 13, 2023 06:38
@oskardudycz oskardudycz marked this pull request as ready for review February 13, 2023 06:38
@oskardudycz oskardudycz changed the title WIP: Added IdentitySession and Lightweight session the default one Added IdentitySession and Lightweight session the default one Feb 13, 2023
@oskardudycz oskardudycz merged commit f17992a into master Feb 13, 2023
@oskardudycz oskardudycz deleted the lightweight_session_default branch February 13, 2023 08:39
@oskardudycz oskardudycz added this to the 6.0.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oskardudycz oskardudycz

Labels
6.x breaking change enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Consider using LightWeightSession as default for Marten's default configuration
2 participants
@oskardudycz @mysticmind