Added AsyncDaemonHealthCheck #2648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
force-pushed
the
master
branch
7 times, most recently
from
6f60ad6
to
0a7a351
Compare
|
@daveHylde, thank you a lot for sending this pull request. July was a bit slow for me because of the longer vacations. I'll try to get the initial round of review in the next week. The delay doesn't come from the fact that this change is ignored, but actually because it's really important and helpful for other users, thus I'd like to have some patient time to go through it. |
selketjah
reviewed
Aug 2, 2023
| } | ||
|
|
||
| [Fact] | ||
| public async Task should_be_healty_with_one_projections_lagging() |
There was a problem hiding this comment.
After looking at the assert statement, I believe this should be unhealthy, not healthy.
There was a problem hiding this comment.
You're right - typo. Good catch
|
The PR was moved to #2679 because of some git dirty tricks 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality for a simple HealthCheck for the async daemon.
This is especially useful when running in a containerized environment such as Kubernetes.