Fixed Marten Exceptions transformations when NpgslCommand is null #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
force-pushed
the
exception_transformer
branch
8 times, most recently
from
326e063
to
0d320f2
Compare
That may happen when the connection string is invalid or is not matching the database configuration (e.g. wrong password). Added `InvalidConnectionStringException` - a dedicated exception type for when the connection string is invalid. Npgsql is throwing a bit of confusing `ArgumentException`, so I think that it'll be more accessible to add more context.
oskardudycz
force-pushed
the
exception_transformer
branch
from
0d320f2
to
b91ea12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That may happen when the connection string is invalid or is not matching the database configuration (e.g. wrong password).
Added
InvalidConnectionStringException- a dedicated exception type for when the connection string is invalid. Npgsql is throwing a bit of confusingArgumentException, so I think that it'll be more accessible to add more context.Fixes #2670