Set DeadLetterEvent as single tenanted for conjoined tenancy
#2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
force-pushed
the
bug/2686-rebuild_conjoined
branch
2 times, most recently
from
0a7853a
to
bacd7bb
Compare
There could be a race condition when session was released, but Queue wasn't completed that caused session to be null. Added nullable annotations to remove the chance of that to appear.
oskardudycz
force-pushed
the
bug/2686-rebuild_conjoined
branch
from
bacd7bb
to
5519956
Compare
…g projection progress in Async Daemon
…g down existing projection progress
…ltitenancy for it DeadLetterEvent references the event with specific sequence. It's always global, and there's no option to replay events for a specific tenant for conjoined tenancy.
oskardudycz
changed the title
DeadLetterEvent as single tenanted for conjoined tenancy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2686.
Set
DeadLetterEventas single tenanted for conjoined tenancy. A dead letter event represents an event skipped for the particular projection. It references that event at a specific global event store sequence. Thus, it has to be global and does not have a tenant. If we rebuild the projection, all read models will be rebuilt using events from all tenants.Added test ensuring that conjoined tenancy is handled correctly.
Enhanced ProjectionUpdateBatch disposal. There could be a race condition when the session was released, but the processing Queue wasn't completed, which caused the session to be null. Added nullable annotations to make that explicit and fixes accordingly (by checking the cancellation token and implementing disposal consistently).
@BrettGFleischer @jeremydmiller FYI