Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream key variants of batched event query operations #2742

Merged

Conversation

elexisvenator
Copy link
Contributor

Added missing IBatchEvents.FetchStreamState(string streamKey)
and IBatchEvents.FetchStream(string streamKey, long version, DateTime? timestamp, long fromVersion).

Nothing too complicated here, just filling in some gaps.

Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elexisvenator looks good to me. Could you add tests tho?

@elexisvenator
Copy link
Contributor Author

Can do :) I have duplicated the tests that exist for the stream ids and changed them to work on the string key versions.

Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot, @elexisvenator; looks good!

@oskardudycz oskardudycz merged commit 1065a98 into JasperFx:master Oct 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants