Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IEvent<TEvent> fanout overload on multistream projection #2748

Merged
merged 8 commits into from
Oct 20, 2023
Merged

Add IEvent<TEvent> fanout overload on multistream projection #2748

merged 8 commits into from
Oct 20, 2023

Conversation

erdtsieck
Copy link
Contributor

@erdtsieck erdtsieck commented Oct 10, 2023 •
edited by oskardudycz
Loading

Fixes #2747

@erdtsieck erdtsieck force-pushed the feature/2747-Add-IEvent-TEvent-fanout-overload-on-multistream-projection branch from f9b7825 to faeae38 Compare October 10, 2023 10:03
erdtsieck added a commit to erdtsieck/marten that referenced this pull request Oct 10, 2023
@erdtsieck
JasperFx#2748 Fixed overload by changing name
f59cf74
erdtsieck added a commit to erdtsieck/marten that referenced this pull request Oct 10, 2023
@erdtsieck
JasperFx#2748 Fixed overload by changing name
6b360ae
@erdtsieck erdtsieck force-pushed the feature/2747-Add-IEvent-TEvent-fanout-overload-on-multistream-projection branch from f59cf74 to 6b360ae Compare October 10, 2023 11:54
erdtsieck added a commit to erdtsieck/marten that referenced this pull request Oct 10, 2023
@erdtsieck
JasperFx#2748 integration test fixed
93a6cb5
jeremydmiller
jeremydmiller requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jeremydmiller jeremydmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some semantic versioning stuff, the actual content is fine as is

@oskardudycz
Copy link
Collaborator

@erdtsieck, could you rebase instead of merging the main branch? That'd be much appreciated.

@erdtsieck
Copy link
Contributor Author

@erdtsieck, could you rebase instead of merging the main branch? That'd be much appreciated.

I'll try next time. Never rebased before. Can I still fix it at this point?

@oskardudycz oskardudycz force-pushed the feature/2747-Add-IEvent-TEvent-fanout-overload-on-multistream-projection branch from 8227f44 to bb48fd3 Compare October 20, 2023 08:11
@oskardudycz
Copy link
Collaborator

@erdtsieck, fine, I did that for you this time 😉

@oskardudycz oskardudycz changed the title #2747 Add IEvent<TEvent> fanout overload on multistream projection Add IEvent<TEvent> fanout overload on multistream projection Oct 20, 2023
@oskardudycz oskardudycz added this to the 6.3.0 milestone Oct 20, 2023
oskardudycz
oskardudycz approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

jeremydmiller
jeremydmiller approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@jeremydmiller jeremydmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes and doing this in the first place. Being strict, or at least trying to be, on SemVer is tedious:(

I'm pulling this in now

@jeremydmiller jeremydmiller merged commit 4d9a828 into JasperFx:master Oct 20, 2023
13 checks passed
jeremydmiller pushed a commit that referenced this pull request Oct 20, 2023
@erdtsieck @jeremydmiller
#2748 Fixed overload by changing name
436c37f
jeremydmiller pushed a commit that referenced this pull request Oct 20, 2023
@erdtsieck @jeremydmiller
#2748 integration test fixed
85b5b42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremydmiller jeremydmiller jeremydmiller approved these changes

@oskardudycz oskardudycz oskardudycz approved these changes

Assignees
No one assigned
Labels
6.x enhancement projections
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

Add IEvent<TEvent> fanout overload on multistream projection
3 participants
@erdtsieck @oskardudycz @jeremydmiller