Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing users to add LINQ order by operators with literal SQL. Close… #2845

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

jeremydmiller
Copy link
Member

…s GH-2843

@jeremydmiller jeremydmiller merged commit c0039f1 into master Dec 5, 2023
10 of 11 checks passed
@jeremydmiller jeremydmiller deleted the ordering branch December 5, 2023 21:42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremydmiller I don't understand all the mechanics on how the docs are deployed, but to me it seems that this should be live-content and be not removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mysticmind I'm aware that Jeremy knows what he does, but I'd like to learn and understand the mechanics that are going on.

My question is because cli.md is now empty, and when I hit "Suggest changes to this page" in Command Line Tooling then I get the empty content too.

Please clarify where the content is coming from. Thanks in advance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you notice, I had checked earlier on phone and then deleted my message after taking a look from laptop. Looks like Jeremy did delete doc content which are not code samples.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow on note, code samples are fetched afresh from the unit tests files and rest of the docs content are as is in the markdown files. If cli.md is empty then Jeremy did mess up that page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got you. Thanks.
I replyd to the email notification I got, so didn't realize you deleted the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants