-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NpgsqlDataSource #2855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a5e5a9
to
a27f178
Compare
@oskardudycz I say we pull this in anytime you'd like. We're not finalizing anything anyway, and we'll take the run through Wolverine soon too. |
…ching NpgsqlDataSourceFactory
…oviding the connection string in AddMarten
5dd41f3
to
da7f07a
Compare
Bumped language version to 12
da7f07a
to
74c1d0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
NpgsqlDataSource
, the recommended way of handling connection management by the Npgsql team. This should also enable more scenarios, like integrating with the Aspire project, easier isolation testing etc.Used
NpgsqlDataSource
throughout the codebase. It should be safe, as NpgsqlDataSource inferits currently the global config upon initialisation.Added possibility to use registered
NpgsqlDataSource
in DI by callingAddMarten().UseNpgsqlDataSource()
helper methods.By default,
DocumentStore
will manage the lifetime of all data sources created by the factory as singletons. When injected from DI, only newly created tenants will be managed; the DI container will manage the main one.Made
ITenancyConfiguration
in-store options lazy, as it's needed only in Runtime, and that enables easier and more flexible configuration.I kept some Store Options as internal, but we can consider making them public depending on the usage patterns.
Currently left the wild permutations of the connection configuration but made them obsolete.
Warning: Bumped the Weasel version, which can cause some binding conflicts in Wolverine.