JasperFx · jeremydmiller · Jan 10, 2024 · Jan 5, 2024 · Jan 9, 2024 · Jan 9, 2024
diff --git a/README.md b/README.md
diff --git a/docs/configuration/environment-checks.md b/docs/configuration/environment-checks.md
@@ -30,4 +30,4 @@ public static async Task use_environment_check()
 }
 ```
 <sup><a href='https://github.com/JasperFx/marten/blob/master/src/CoreTests/Examples/EnvironmentChecks.cs#L10-L30' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_use_environment_check_in_hosted_service' title='Start of snippet'>anchor</a></sup>
-<!-- endSnippet -->
+<!-- endSnippet -->
diff --git a/docs/configuration/hostbuilder.md b/docs/configuration/hostbuilder.md
diff --git a/docs/configuration/json.md b/docs/configuration/json.md
@@ -3,9 +3,9 @@
 ::: tip
 Newtonsoft.Json is still the default JSON serializer in Marten for backwards compatibility
 with previous Marten versions and because it is the most battle-hardened JSON serializer
-in the .Net space that "just works." 
+in the .Net space that "just works."
 
-If you're working on a new system, we recommend enabling the System.Text.Json integration for improved throughput. 
+If you're working on a new system, we recommend enabling the System.Text.Json integration for improved throughput.
 :::
 
 An absolutely essential ingredient in Marten's persistence strategy is JSON serialization of the document objects. Marten aims to make the
@@ -189,10 +189,10 @@ You can also use other options of `NonPublicMembersStorage`:
 
 - `NonPublicDefaultConstructor` - allows deserialization using non-public default constructor,
 - `NonPublicConstructor` - allows deserialization using any constructor. Construction resolution uses the following precedence:
-  1. Constructor with `JsonConstructor` attribute.
-  2. Constructor with the biggest parameters' count.
-  3. If two constructors have the same parameters' count, use public or take the first one.
-  4. Use default constructor.
+    1. Constructor with `JsonConstructor` attribute.
+    2. Constructor with the biggest parameters' count.
+    3. If two constructors have the same parameters' count, use public or take the first one.
+    4. Use default constructor.
 - `All` - Use both properties with non-public setters and non-public constructors.
 
 When using `System.Text.Json` the only support for private properties is to mark the field using [\[JsonInclude\]](https://docs.microsoft.com/en-us/dotnet/api/system.text.json.serialization.jsonincludeattribute?view=net-6.0) attribute.
@@ -360,8 +360,8 @@ in order to create the correct SQL queries within JSON bodies.
 :::
 
 ::: warning
-The code below is provided as an example only, `Jil` is no longer maintained 
-and should not be used in your application. 
+The code below is provided as an example only, `Jil` is no longer maintained
+and should not be used in your application.
 :::
 
 <!-- snippet: sample_JilSerializer -->

diff --git a/docs/configuration/storeoptions.md b/docs/configuration/storeoptions.md
@@ -328,5 +328,5 @@ var store = DocumentStore.For(_ =>
     _.NameDataLength = 100;
 });
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/CoreTests/StoreOptionsTests.cs#L286-L295' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_setting-name-data-length' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/CoreTests/StoreOptionsTests.cs#L296-L305' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_setting-name-data-length' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
diff --git a/docs/diagnostics.md b/docs/diagnostics.md
@@ -245,6 +245,19 @@ public interface IMartenSessionLogger
     /// <param name="ex"></param>
     void LogFailure(NpgsqlCommand command, Exception ex);
 
+    /// <summary>
+    ///     Log a command that executed successfully
+    /// </summary>
+    /// <param name="batch"></param>
+    void LogSuccess(NpgsqlBatch batch);
+
+    /// <summary>
+    ///     Log a batch that failed
+    /// </summary>
+    /// <param name="batch"></param>
+    /// <param name="ex"></param>
+    void LogFailure(NpgsqlBatch batch, Exception ex);
+
     /// <summary>
     ///     Called immediately after committing an IDocumentSession
     ///     through SaveChanges() or SaveChangesAsync()
@@ -261,7 +274,7 @@ public interface IMartenSessionLogger
     public void OnBeforeExecute(NpgsqlCommand command);
 }
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten/IMartenLogger.cs#L11-L67' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_imartenlogger' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten/IMartenLogger.cs#L11-L81' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_imartenlogger' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 To apply these logging abstractions, you can either plug your own `IMartenLogger` into the `StoreOptions` object and allow that default logger to create the individual session loggers:
@@ -274,7 +287,7 @@ var store = DocumentStore.For(_ =>
     _.Logger(new ConsoleMartenLogger());
 });
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/CoreTests/StoreOptionsTests.cs#L146-L153' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_plugging-in-marten-logger' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/CoreTests/StoreOptionsTests.cs#L156-L163' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_plugging-in-marten-logger' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 You can also directly apply a session logger to any `IQuerySession` or `IDocumentSession` like this:
@@ -286,7 +299,7 @@ using var session = store.LightweightSession();
 // Replace the logger for only this one session
 session.Logger = new RecordingLogger();
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/CoreTests/StoreOptionsTests.cs#L155-L161' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_plugging-in-session-logger' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/CoreTests/StoreOptionsTests.cs#L165-L171' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_plugging-in-session-logger' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 The session logging is a different abstraction specifically so that you _could_ track database commands issued per session. In effect, my own shop is going to use this capability to understand what HTTP endpoints or service bus message handlers are being unnecessarily chatty in their database interactions. We also hope that the contextual logging of commands per document session makes it easier to understand how our systems behave.
@@ -317,6 +330,16 @@ public class ConsoleMartenLogger: IMartenLogger, IMartenSessionLogger
             Console.WriteLine($"  {p.ParameterName}: {GetParameterValue(p)}");
     }
 
+    public void LogSuccess(NpgsqlBatch batch)
+    {
+        foreach (var command in batch.BatchCommands)
+        {
+            Console.WriteLine(command.CommandText);
+            foreach (var p in command.Parameters.OfType<NpgsqlParameter>())
+                Console.WriteLine($"  {p.ParameterName}: {GetParameterValue(p)}");
+        }
+    }
+
     private static object? GetParameterValue(NpgsqlParameter p)
     {
         if (p.Value is IList enumerable)
@@ -334,15 +357,26 @@ public class ConsoleMartenLogger: IMartenLogger, IMartenSessionLogger
 
     public void LogFailure(NpgsqlCommand command, Exception ex)
     {
-        _stopwatch?.Stop();
-
         Console.WriteLine("Postgresql command failed!");
         Console.WriteLine(command.CommandText);
         foreach (var p in command.Parameters.OfType<NpgsqlParameter>())
             Console.WriteLine($"  {p.ParameterName}: {p.Value}");
         Console.WriteLine(ex);
     }
 
+    public void LogFailure(NpgsqlBatch batch, Exception ex)
+    {
+        Console.WriteLine("Postgresql command failed!");
+        foreach (var command in batch.BatchCommands)
+        {
+            Console.WriteLine(command.CommandText);
+            foreach (var p in command.Parameters.OfType<NpgsqlParameter>())
+                Console.WriteLine($"  {p.ParameterName}: {p.Value}");
+        }
+
+        Console.WriteLine(ex);
+    }
+
     public void RecordSavedChanges(IDocumentSession session, IChangeSet commit)
     {
         _stopwatch?.Stop();
@@ -359,7 +393,7 @@ public class ConsoleMartenLogger: IMartenLogger, IMartenSessionLogger
     }
 }
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten/IMartenLogger.cs#L69-L136' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_consolemartenlogger' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten/IMartenLogger.cs#L83-L171' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_consolemartenlogger' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 ## Accessing Diagnostics
@@ -415,7 +449,7 @@ The `IMartenLogger` can be swapped out on any `IQuerySession` or `IDocumentSessi
 // session to pipe Marten logging to the xUnit.Net output
 theSession.Logger = new TestOutputMartenLogger(_output);
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/EventSourcingTests/archiving_events.cs#L227-L233' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_replacing_logger_per_session' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/EventSourcingTests/archiving_events.cs#L231-L237' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_replacing_logger_per_session' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 ## Previewing the PostgreSQL Query Plan

diff --git a/docs/documents/querying/linq/sql.md b/docs/documents/querying/linq/sql.md
@@ -18,5 +18,5 @@ public void query_with_matches_sql()
     user.Id.ShouldBe(u.Id);
 }
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/DocumentDbTests/Reading/query_by_sql.cs#L263-L278' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_query_with_matches_sql' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/DocumentDbTests/Reading/query_by_sql.cs#L267-L282' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_query_with_matches_sql' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
diff --git a/docs/documents/querying/sql.md b/docs/documents/querying/sql.md
@@ -50,7 +50,7 @@ a document body, but in that case you will need to supply the full SQL statement
 var sumResults = await session
     .QueryAsync<int>("select count(*) from mt_doc_target");
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/DocumentDbTests/Reading/query_by_sql.cs#L372-L377' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_query_by_full_sql' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/DocumentDbTests/Reading/query_by_sql.cs#L376-L381' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_query_by_full_sql' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 When querying single JSONB properties into a primitive/value type, you'll need to cast the value to the respective postgres type:
@@ -61,7 +61,7 @@ When querying single JSONB properties into a primitive/value type, you'll need t
 var times = await session.QueryAsync<DateTimeOffset>(
     "SELECT (data ->> 'ModifiedAt')::timestamptz from mt_doc_user");
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/DocumentDbTests/Reading/query_by_sql.cs#L326-L331' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_using-queryasync-casting' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/DocumentDbTests/Reading/query_by_sql.cs#L330-L335' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_using-queryasync-casting' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 The basic rules for how Marten handles user-supplied queries are:

diff --git a/docs/events/archiving.md b/docs/events/archiving.md
@@ -35,7 +35,7 @@ var events = await theSession.Events
     .Where(x => x.IsArchived)
     .ToListAsync();
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/EventSourcingTests/archiving_events.cs#L162-L169' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_querying_for_archived_events' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/EventSourcingTests/archiving_events.cs#L166-L173' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_querying_for_archived_events' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 You can also query for all events both archived and not archived with `MaybeArchived()`
@@ -47,5 +47,5 @@ like so:
 var events = await theSession.Events.QueryAllRawEvents()
     .Where(x => x.MaybeArchived()).ToListAsync();
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/EventSourcingTests/archiving_events.cs#L193-L198' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_query_for_maybe_archived_events' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/EventSourcingTests/archiving_events.cs#L197-L202' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_query_for_maybe_archived_events' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
diff --git a/docs/events/projections/projection-by-event-type.md b/docs/events/projections/projection-by-event-type.md
@@ -1,19 +0,0 @@
-# Projecting by Event Type
-
-While projections can target specific stream or streams, it is also possible to project by event types. The following sample demonstrates this with the `CandleProjection` that implements the `ViewProjection` interface to build `Candle` projections from events of type `Tick`.
-
-Introduce a type to hold candle data:
-
-<[sample:sample-type-candle]>
-
-This data will then be populated and updated from observing ticks:
-
-<[sample:sample-type-tick]>
-
-We then introduce a projection that subscribes to the 'Tick' event:
-
-<[sample:sample-candleprojection]>
-
-Lastly, we configure the Event Store to use the newly introduced projection:
-
-<[sample:sample-project-by-event-type]>