Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch implementation using pure PL/pgSQL #2923

Merged
merged 9 commits into from Jan 26, 2024
Merged

Conversation

mysticmind
Copy link
Member

@mysticmind mysticmind commented Jan 22, 2024

The following are changes included:

This implementation will work with Postgres 9.6 and above.

@mysticmind mysticmind changed the title Patch implementation using PL/pgSQL Patch implementation using pure PL/pgSQL Jan 22, 2024
@mysticmind mysticmind marked this pull request as draft January 23, 2024 13:43
@mysticmind mysticmind marked this pull request as ready for review January 24, 2024 12:25
@jeremydmiller
Copy link
Member

It looks like a functional equivalent to the old Javascript version. Whenever we can beat Weasel into correctly determining the function body changes correctly, I'm ready to pull this in.

@mysticmind
Copy link
Member Author

mysticmind commented Jan 26, 2024

It looks like a functional equivalent to the old Javascript version. Whenever we can beat Weasel into correctly determining the function body changes correctly, I'm ready to pull this in.

I have retrofitted the functions as per the format where the delta is all fine with Weasel. That is why the unit tests are all green. So you are good to pull it in.

@jeremydmiller jeremydmiller merged commit 5a9f396 into master Jan 26, 2024
11 checks passed
@jeremydmiller jeremydmiller deleted the plpgsql_patching branch January 26, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimized Patch operations *after* V4
2 participants