Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3078 Providing a version for aggregating that is too high should aggregate to null #3079

Conversation

erdtsieck
Copy link
Contributor

No description provided.

@jeremydmiller
Copy link
Member

@erdtsieck I'm not sure I agree with this one

@erdtsieck
Copy link
Contributor Author

@erdtsieck I'm not sure I agree with this one

@jeremydmiller Well, I do not expect you to. My intent is to be able to do polling whether an aggregate has arrived at an expected point, as @oskardudycz did in his example: https://github.com/oskardudycz/EventSourcing.NetCore/blob/main/Sample/Helpdesk.Wolverine/Helpdesk.Api/Incidents/ResolutionBatch/GettingIncidentResolutionBatch/GetIncidentsBatchResolution.cs

But you could of course just do the aggregate.version check yourself instead of using the API

Or another API method?

@jeremydmiller
Copy link
Member

There's the FetchStreamStateAsync() API you could use for that that would be much, much lighter weight. Not sure what Oskar was up to there.

@jeremydmiller
Copy link
Member

I think I'd rather have it throw an exception rather than do that, and I think I disagree w/ that too because it's filtering the events and might not even know what the current stream version is

@jeremydmiller jeremydmiller merged commit ba0515b into JasperFx:master Apr 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants