Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remnants of timestamp support still present #120

Open
marschall opened this issue Jul 21, 2019 · 2 comments
Open

Remnants of timestamp support still present #120

marschall opened this issue Jul 21, 2019 · 2 comments
Labels

Comments

@marschall
Copy link
Member

Even though timestamp support was removed in JAVAMONEY-89 it is still referenced in several places.

  • class comment of ConversionContext
  • class comment of CurrencyConversion
  • class comment of CurrencyContext
  • class comment of CurrencyQuery, fixed in Update CurrencyQuery to Make Timestamp Optional #117
  • AbstractQuery#KEY_QUERY_TIMESTAMP, not referenced anywhere
  • CurrencyConversionExceptionTest#CONTEXT100
  • MonetaryRoundingsTest#testMonetaryRoundingsGetRoundingQueryWithLongTS()
  • MonetaryRoundingsTest#testIsRoundingsAvailable_Query()
@keilw
Copy link
Member

keilw commented Jul 29, 2019

Seems removed by PRs like #119. What about the BP, do we care or leave it there? As it should go away with the next version, I am not sure, if it would break anything there, if not, then we may just keep it as it is.

@marschall
Copy link
Member Author

marschall commented Jul 29, 2019

#119 removes only one part, more remains to do
Removing AbstractQuery#KEY_QUERY_TIMESTAMP is a breaking change, I'm not sure we want to do this, maybe only deprecate.
As for the BP I'm not sure what the policy is. Most of these things are cosmetic only and do not affect functionality.

@keilw keilw added the deferred label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants