Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with -release instead of -source -target #95

Merged
merged 1 commit into from Sep 4, 2018

Conversation

marschall
Copy link
Member

@marschall marschall commented Sep 2, 2018

In order to have safe cross compilation and avoid issues like
JavaMoney/jsr354-ri#189 we need to use
-release instead of -source -target, see JEP 247 [1]

[1] http://openjdk.java.net/jeps/247


This change is Reviewable

In order to have safe cross compilation avoid issues like
JavaMoney/jsr354-ri#189 we need to use
-release instead of -source -target, see JEP 247 [1]

 [1] http://openjdk.java.net/jeps/247
@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.898% when pulling a87d6b7 on marschall:compile-with-release into f8c1f43 on JavaMoney:master.

@keilw keilw merged commit c4cd63d into JavaMoney:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants