My1.15 adds #7
Closed
My1.15 adds #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditions made for UPOS 1.15
Control implementations upgraded to 1.15 using the controls and services upgraded in contracts repo. Relevant changes only in ElectronicValueRW (FiscalPrinter changes have been made in previous commits).
Missing implementation for method registerServiceToMedium added.
- Method setPaymentMedia added. - Parameter object in several methods changed: Type changed from Object[] to Object, name to obj to match the UPOS specification.
kuniss
reviewed
May 28, 2022
|
I'm going to reject this PR because the code will be generated either through logic in javapos-code-generator project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version numbers incremented for all devices (to 1.15 / 1015000).
deviceVersion115 added to BaseJposControl.
For all control implementations, service115 has been added, deviceControlVersion incremented to deviceVersion115 within the constructor and service115 initialized in setDeviceService method, similar to the initialization of service114.
For ElectronicValueRW, additional getter and method implementations have been added. Implementations similar to implementations of other getter and method implementations.
TODO: No implementations have been added to tests.