Added support for news channel #1162
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealYusufIsmail
force-pushed
the
news_channel
branch
from
b4e2937
to
d08c831
Compare
2 tasks
added follow Channel method to news channel Removed channel type SERVER_STORE_CHANNEL as it was removed by discord a long time ago ServerTextChannel now extends ServerMessageChannel and so does NewsChannel This is because everything apart from slow mode is the same. Slowmode is in the interface ServerTextChannel
RealYusufIsmail
force-pushed
the
news_channel
branch
from
d08c831
to
e775cf5
Compare
added follow Channel method to news channel Removed channel type SERVER_STORE_CHANNEL as it was removed by discord a long time ago ServerTextChannel now extends ServerMessageChannel and so does NewsChannel This is because everything apart from slow mode is the same. Slowmode is in the interface ServerTextChannel
RealYusufIsmail
force-pushed
the
news_channel
branch
from
e775cf5
to
8423346
Compare
|
Unable to work on. Most is done just testing and some minor changes are needed so if someone wants to take over let me know. |
RealYusufIsmail
commented
Apr 17, 2023
| import java.util.Optional; | ||
| import java.util.concurrent.CompletableFuture; | ||
|
|
||
| public interface ServerMessageChannel extends RegularServerChannel, TextChannel, Mentionable, Categorizable { |
There was a problem hiding this comment.
Make it extend TextableRegularServerChannel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changelog
This is because everything apart from slow mode is the same. Slowmode is in the interface ServerTextChannel
Breaking Changes
ServerTextChannel and, (consistently named) ServerNewsChannel now inhert ServerMessageChannel
Description
Closes: #453
Footnotes
At least started a running bot instance with your changes and triggered an event so your changed code gets executed. ↩