Let InteractionOriginalResponseUpdater implement Deletable. #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saladoc
added
the
improvement
felldo
requested changes
Feb 2, 2023
...core/src/main/java/org/javacord/core/interaction/InteractionOriginalResponseUpdaterImpl.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/javacord/api/entity/message/internal/InteractionMessageBuilderDelegate.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/javacord/core/entity/message/InteractionMessageBuilderDelegateImpl.java
Outdated
Show resolved
Hide resolved
Saladoc
force-pushed
the
GH1203-deletable-interaction-updates
branch
from
be3cb13
to
11661b2
Compare
|
I wanted to omit "breaking" api changes but you're right, of those are internal anyway and using null as an audit log reason is safe all up to the |
Saladoc
force-pushed
the
GH1203-deletable-interaction-updates
branch
from
11661b2
to
ef9d45c
Compare
- Update the documentation to specify that audit log reason support depends on discord.
Saladoc
force-pushed
the
GH1203-deletable-interaction-updates
branch
from
ef9d45c
to
4be6071
Compare
felldo
requested changes
Feb 2, 2023
Comment on lines
+33
to
+35
| default CompletableFuture<Void> deleteInitialResponse(InteractionBase interaction) { | ||
| return deleteInitialResponse(interaction, null); | ||
| } |
There was a problem hiding this comment.
Actually, this can be removed since passing null as the reason anywhere else has the same effect as this method currently.
In the InteractionMessageBuilder the method overload with the reason is also missing,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changelog
Breaking Changes
Description
Closes: #1203
Notes: Audit reasons being ignored if not supported is made explicit in the documentation. InteractionOriginalResponseUpdater is safe to store and reuse.
Footnotes
At least started a running bot instance with your changes and triggered an event so your changed code gets executed. ↩