-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let InteractionOriginalResponseUpdater implement Deletable. #1209
base: master
Are you sure you want to change the base?
Let InteractionOriginalResponseUpdater implement Deletable. #1209
Conversation
...core/src/main/java/org/javacord/core/interaction/InteractionOriginalResponseUpdaterImpl.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/javacord/api/entity/message/internal/InteractionMessageBuilderDelegate.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/javacord/core/entity/message/InteractionMessageBuilderDelegateImpl.java
Outdated
Show resolved
Hide resolved
be3cb13
to
11661b2
Compare
I wanted to omit "breaking" api changes but you're right, of those are internal anyway and using null as an audit log reason is safe all up to the |
11661b2
to
ef9d45c
Compare
- Update the documentation to specify that audit log reason support depends on discord.
ef9d45c
to
4be6071
Compare
default CompletableFuture<Void> deleteInitialResponse(InteractionBase interaction) { | ||
return deleteInitialResponse(interaction, null); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this can be removed since passing null as the reason anywhere else has the same effect as this method currently.
In the InteractionMessageBuilder
the method overload with the reason is also missing,
Checklist
Changelog
Breaking Changes
Description
Closes: #1203
Notes: Audit reasons being ignored if not supported is made explicit in the documentation. InteractionOriginalResponseUpdater is safe to store and reuse.
Footnotes
At least started a running bot instance with your changes and triggered an event so your changed code gets executed. ↩