Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isBotUser() and isRegularUser() to MessageAuthor #432

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Saladoc
Copy link
Member

@Saladoc Saladoc commented Jan 28, 2019

No description provided.

@Vampire
Copy link
Member

Vampire commented Jan 28, 2019

Hm, I remember we talked about this method previously (Bastian and I afair, but in some channel) and came to the conclusion not to add it, but I don't remember the reasoning.

@Bastian
Copy link
Member

Bastian commented Jan 28, 2019

The reason was, that it might cause even more confusion with the message author class:

  • If isBot() is false someone might think that isUser() is true then.
  • If isUser() is false someone might think that isBot is true then.

Maybe something like isBotUser() and isHumanUser() might be possible.

@Vampire
Copy link
Member

Vampire commented Jan 28, 2019

I think we also considered those and decided against them. :-D

@Saladoc
Copy link
Member Author

Saladoc commented Jan 28, 2019

Not having a method to check if a MessageAuthor is a bot account is just plain counterintuitive though as it is one of the most common use cases so we should include some way.

I'd probably do all three isUser(), isBotUser(), and isHumanUser(), although I dislike the latter name.

@Vampire
Copy link
Member

Vampire commented Jan 29, 2019

@Bastian Bastian added the low priority An issue or pull request with a low priority label Mar 23, 2019
@Saladoc Saladoc force-pushed the messageauthor-isbot branch 2 times, most recently from 2737e49 to 143f588 Compare April 9, 2019 13:33
@Bastian Bastian added this to the Next Version milestone Apr 9, 2019
@Bastian Bastian changed the title Add isBot method to MessageAuthor. Add isBotUser() and isRegularUser() to MessageAuthor Apr 9, 2019
@Bastian Bastian merged commit a83901b into Javacord:development Apr 9, 2019
@Saladoc Saladoc deleted the messageauthor-isbot branch April 9, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority An issue or pull request with a low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants