Quickfix for new channel types #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bastian
added
the
medium priority
This commit only adds very basic support for these new channel types. News channels get treated as normal server text channels and store channels get completely ignored.
Bastian
force-pushed
the
new-channeltypes-quickfix
branch
from
ac7a287
to
8bc0dbd
Compare
Saladoc
approved these changes
Mar 30, 2019
|
I don't think that's necessary, as this is only a temporary solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit only adds very basic support for the new channel types.
News channels get treated as normal server text channels and store channels get completely ignored.
It also cleans up the switch-statements a little bit by using the enum instead of hard-coding the integer values.
Better support will be added when we get more information from Discord in discord/discord-api-docs#881.