Add ratelimiter to allow custom hard-coded global ratelimits #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On larger bots, it is possible to hit the global ratelimit of 50/1. Preventing to hit this global ratelimit is not possible with just the ratelimit HTTP-headers that we receive from Discord, but only with hard-coded limits. As the limits could change over-time (and there might even some increased limits for large bots?) it's no option to hard-code them directly into the Javacord code.
This PR allows users to set their own ratelimits in the
DiscordApiBuilder
. A default implementation is available for local ratelimits that allows users to set a hard-coded limit. It is possible to write custom implementations that allow more complex ratelimiters that can for example share their state across multiple machines.The code can be used like this: