Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the "_new" fields #611

Merged
merged 1 commit into from Mar 22, 2021
Merged

Switch to the "_new" fields #611

merged 1 commit into from Mar 22, 2021

Conversation

felldo
Copy link
Member

@felldo felldo commented Sep 20, 2020

No description provided.

@Bastian Bastian added the medium priority An issue or pull request with a medium priority label Sep 20, 2020
Joshix-1
Joshix-1 reviewed Sep 20, 2020
View reviewed changes
javacord-core/src/main/java/org/javacord/core/entity/channel/ServerChannelImpl.java Show resolved Hide resolved
javacord-core/src/main/java/org/javacord/core/entity/channel/ServerChannelImpl.java Show resolved Hide resolved
javacord-core/src/main/java/org/javacord/core/entity/permission/PermissionsImpl.java Show resolved Hide resolved
javacord-core/src/main/java/org/javacord/core/entity/permission/RoleImpl.java Show resolved Hide resolved
javacord-core/src/main/java/org/javacord/core/entity/permission/RoleImpl.java Show resolved Hide resolved
javacord-core/src/main/java/org/javacord/core/util/handler/channel/ChannelUpdateHandler.java Outdated Show resolved Hide resolved
javacord-core/src/main/java/org/javacord/core/util/handler/channel/ChannelUpdateHandler.java Outdated Show resolved Hide resolved
@felldo felldo force-pushed the new_fields branch 2 times, most recently from 6b7bcd8 to 7c80a4b Compare October 4, 2020 18:50
@Bastian
Copy link
Member

Bastian commented Dec 29, 2020

The _new suffix does no longer exist in v8 afaik?

@felldo
Copy link
Member Author

felldo commented Dec 29, 2020

The _new suffix does no longer exist in v8 afaik?

This is correct. But I think we still have to convert the type to long of the permissions to respect the new size. But maybe #679 can implement it right away

@Bastian
Copy link
Member

Bastian commented Dec 29, 2020

Agreed, we should switch to long.
I think it's easier if you just remove the _new suffix from your PR and I merge it after #679.

@Joshix-1
Copy link
Member

This should get high priority as it is necessary for switching to v8.

@Bastian Bastian added this to the Next Version milestone Mar 18, 2021
@felldo
Copy link
Member Author

felldo commented Mar 18, 2021 •
edited

This is now ready to be merged if everything is alright from your side

@felldo felldo linked an issue Mar 18, 2021 that may be closed by this pull request
Switch to the new "_new" fields #588
Closed
@Joshix-1 Joshix-1 added high priority An issue or pull request with a high priority and removed medium priority An issue or pull request with a medium priority labels Mar 19, 2021
@felldo felldo linked an issue Mar 20, 2021 that may be closed by this pull request
Upgrade to gateway version v8 #642
Closed
@felldo felldo requested a review from Joshix-1 March 22, 2021 19:44
Joshix-1
Joshix-1 approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@Joshix-1 Joshix-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@felldo felldo merged commit 2ed850d into Javacord:development Mar 22, 2021
@felldo felldo deleted the new_fields branch April 2, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bastian Bastian Bastian left review comments

@Joshix-1 Joshix-1 Joshix-1 approved these changes

Assignees
No one assigned
Labels
high priority An issue or pull request with a high priority
Projects
None yet
Milestone
Version 3.2.0
Development

Successfully merging this pull request may close these issues.

Upgrade to gateway version v8 Switch to the new "_new" fields
3 participants
@felldo @Bastian @Joshix-1