add chat color customizability to groups #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this break loading existing groups? I wonder what the color will be for missing entries in the json. Let me know if you tested that. |
|
nah it seems to load fine for existing groups, it just shows up as (0,0,0) in game. In the json they are just missing the "color" field, but once a group update is applied they will be backfilled with (0,0,0,0). |
|
Looks good, I'll be publishing this in the hour. |
JavidPack
added a commit
that referenced
this pull request
Feb 20, 2022
|
Just so you know, this approach does break all mod commands, you might want to fix this for TCR-TerrariaChatRelay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I would like to add this feature! It partially addresses #38. I may try to add prefixes in the future.
I have tried this alongside TCR-TerrariaChatRelay which uses the same method to intercept chat messages, and it works fine.
I wasn't able to set a chat color for Admin because it seems that it's created on mod load rather than stored in the database. I didn't really need it now though so I decided I'll leave it as is and maybe try again in the future.