Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal pytree checks for linops. (Better testing needed in future). #222

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

daniel-dodd
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@daniel-dodd daniel-dodd changed the base branch from refactor_gpjax_to_pytrees to v0.6 April 11, 2023 11:26
@thomaspinder
Copy link
Collaborator

Thanks @daniel-dodd - can you rebase/merge from v0.6 please? It looks like you have conflicts and the newest set of tests are not being run.

Signed-off-by: Daniel Dodd <daniel_dodd@icloud.com>
@thomaspinder
Copy link
Collaborator

All LGTM. Will merge once tests have passed.

@thomaspinder thomaspinder merged commit 6ec004e into v0.6 Apr 11, 2023
@thomaspinder thomaspinder deleted the pytree_tests_for_linops branch April 11, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants