Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static field to base, update tests to run on 3.11, fix 3.11 compatibility #246

Merged
merged 6 commits into from
Apr 30, 2023

Conversation

daniel-dodd
Copy link
Member

@daniel-dodd daniel-dodd commented Apr 30, 2023

This PR comprises the following changes:

  • (1) Add static_field to base, and use this in the testing.

  • (2) Limit simple_pytree imports to 3 places (and the tests only):

    • (a)gpjax.base
    • (b)gpjax.linops.linear_operator (We should update this to a module in future).
    • (c)gpjax.dataset (We should update this to a module in future).

There should be no other imports.

  • Will need to remove simple_pytree imports from the docs_update branch in a separate PR.
  • Perhaps ought to consider (in a future PR), only using Module and limiting simple_pytree import to gpjax.base.

This PR also fixes compatibility issues with Python 3.11, that requires dataclass fields to be hashable (while jax.Arrays are not...).

@daniel-dodd daniel-dodd changed the title Add static field to base Add static field to base, update tests to run on 3.11 Apr 30, 2023
@daniel-dodd daniel-dodd changed the title Add static field to base, update tests to run on 3.11 Add static field to base, update tests to run on 3.11, fix 3.11 compatibility Apr 30, 2023
Copy link
Contributor

@frazane frazane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@frazane frazane merged commit 731e088 into v0.6 Apr 30, 2023
10 checks passed
@frazane frazane deleted the add_static_field_to_base branch April 30, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants