Add isotropy test #271
Merged
Add isotropy test #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomaspinder, this bug was fixed because now we pass a lengthscale upon defining a class that by default this is a single dimension, giving isotropy. But what happens if the active dims and the lengthscale are different sizes (e.g., lengthscale of |
daniel-dodd
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failurebefore committing.Description
In GPJax versions <0.6, we have a bug that prevented users defining an isotropic kernel when their data was greater than a single dimension. This issue was inadvertently fixed in the v0.6 release. This PR simply adds a test to make sure an isotropic kernel can be specified.
Issue Number: #237