-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integrator/likelihoods doc #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To merge:
Looks good @thomaspinder. Left some comments.
For future:
Its nice that you break down the AbstractLikelihood
down. As a further suggestion, it would be nice if we explicitly demonstrated what a user would have to code themselves if they wanted to add their own likelihood (like we do in the kernels guide), as an example. E.g., via a Poisson or Bernoulli (or Both). You could even maybe have a table that breaks things down with the maths and the code for the link functions, what the data looks like under each scenario -> e.g., count use Poisson, for Binary use Bernoulli, etc.
And it would be good to explicitly have links/ advertise custom likelihood, kernel, mean function etc, somewhere in our docs.
Co-authored-by: Daniel Dodd <daniel_dodd@icloud.com> Signed-off-by: Thomas Pinder <tompinder@live.co.uk>
Co-authored-by: Daniel Dodd <daniel_dodd@icloud.com> Signed-off-by: Thomas Pinder <tompinder@live.co.uk>
Co-authored-by: Daniel Dodd <daniel_dodd@icloud.com> Signed-off-by: Thomas Pinder <tompinder@live.co.uk>
Co-authored-by: Daniel Dodd <daniel_dodd@icloud.com> Signed-off-by: Thomas Pinder <tompinder@live.co.uk>
Co-authored-by: Daniel Dodd <daniel_dodd@icloud.com> Signed-off-by: Thomas Pinder <tompinder@live.co.uk>
Co-authored-by: Daniel Dodd <daniel_dodd@icloud.com> Signed-off-by: Thomas Pinder <tompinder@live.co.uk>
Thanks @daniel-dodd - all suggestions actioned. |
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failure
before committing.Description
This PR introduces a piece of documentation that provides users with a guide to likelihood functions and how the integration strategy attached to a likelihood function can be changed.
Issue Number: #295 #294