Smoke testing #307
Merged
Smoke testing #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-dodd
reviewed
Jun 15, 2023
|
very minor nit: if you actually check return values for correctness, it's not a smoke test, then it's a function integration test 😉 smoke test is just "run it and see that it doesn't blow up"... |
st--
reviewed
Jun 15, 2023
Ahh, interesting. I always thought they were one of the same. Thanks! |
daniel-dodd
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failurebefore committing.Description
This PR introduces a smoke test for the regression workflow facilitated by GPJax. It asserts that the predictive mean, predictive standard deviation, MLL evaluate to ground truths.
Issue Number: #303 #304 #305