Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstring tester #317

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Docstring tester #317

merged 5 commits into from
Jun 21, 2023

Conversation

thomaspinder
Copy link
Collaborator

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've formatted the new code by running poetry run pre-commit run --all-files --show-diff-on-failure before committing.
  • [-] I've added tests for new code.
  • [-] I've added docstrings for the new code.

Description

This PR introduces interrogate to the test tooling of GPJax. This library measures docstring coverage and will error when the coverage drops by a prespecified rate. A forthcoming PR improves the docstring coverage, so the current coverage threshold is set at 64%.

Issue Number: #316

@thomaspinder thomaspinder added the testing Testing label Jun 18, 2023
@thomaspinder thomaspinder added this to the v1.0.0 milestone Jun 18, 2023
@thomaspinder thomaspinder self-assigned this Jun 18, 2023
@thomaspinder thomaspinder marked this pull request as ready for review June 20, 2023 09:11
Signed-off-by: Thomas Pinder <tompinder@live.co.uk>
Copy link
Contributor

@ingmarschuster ingmarschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@thomaspinder thomaspinder merged commit fbf2a66 into main Jun 21, 2023
21 checks passed
@thomaspinder thomaspinder deleted the docstring_tester branch June 21, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants