Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed schedule peak_value to 1e-2 for the svgp notebook so it does not give nans #324

Conversation

stefanosele
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've formatted the new code by running poetry run pre-commit run --all-files --show-diff-on-failure before committing.
  • I've added tests for new code.
  • I've added docstrings for the new code.

Description

Current uncollapsed_vi.py notebook gives me nans when I run it locally with the scheduler peaked at 0.1. I have changed the peak_value=0.01 to avoid the issue. Optimisation works as expected after that.
Issue Number: N/A

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into GPJax!

If you have not heard from us in a while, please feel free to ping @gpjax/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on Slack for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@thomaspinder thomaspinder self-requested a review June 22, 2023 06:17
@thomaspinder thomaspinder added the bug Something isn't working label Jun 22, 2023
@thomaspinder thomaspinder added this to the v1.0.0 milestone Jun 22, 2023
@thomaspinder thomaspinder merged commit 549270f into JaxGaussianProcesses:main Jun 22, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants