Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in BasisFunctionComputation #326

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Bugfix in BasisFunctionComputation #326

merged 1 commit into from
Jun 24, 2023

Conversation

frazane
Copy link
Contributor

@frazane frazane commented Jun 23, 2023

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've formatted the new code by running poetry run pre-commit run --all-files --show-diff-on-failure before committing.
  • I've added tests for new code.
  • I've added docstrings for the new code.

Description

The scaling was only applied to one of the arguments here:

z1 = self.compute_features(x)
z2 = self.compute_features(y)
z1 /= self.kernel.num_basis_fns
return self.kernel.base_kernel.variance * jnp.matmul(z1, z2.T)

but should be applied outside the matrix computation. This PR fixes this.

Issue Number: N/A

@thomaspinder thomaspinder added the bug Something isn't working label Jun 24, 2023
@thomaspinder thomaspinder added this to the v1.0.0 milestone Jun 24, 2023
@thomaspinder thomaspinder merged commit e98050e into main Jun 24, 2023
21 checks passed
@thomaspinder thomaspinder deleted the rff-bugfix branch June 24, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants