Cleanup src #419
Merged
Cleanup src #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymoss
reviewed
Nov 28, 2023
docs/examples/graph_kernels.py
Outdated
| @@ -158,6 +174,7 @@ | |||
| model=posterior, | |||
| objective=jit(gpx.ConjugateMLL(negative=True)), | |||
| train_data=D, | |||
| max_iters=1000 | |||
There was a problem hiding this comment.
did this fix it? Seems like a huge number for LBFGS
There was a problem hiding this comment.
No - the error persists. Works locally
henrymoss
reviewed
Nov 28, 2023
Comment on lines
+511
to
+515
| covariance = Ktt - jnp.matmul(Kxt.T, Sigma_inv_Kxt) | ||
| covariance += cola.ops.I_like(covariance) * self.prior.jitter | ||
| covariance = cola.PSD(covariance) | ||
| rval = GaussianDistribution(jnp.atleast_1d(mean.squeeze()), covariance) | ||
| if m == 1: | ||
| return rval | ||
| else: | ||
| return ReshapedDistribution(rval, (n_test, m)) | ||
|
|
||
| return GaussianDistribution(jnp.atleast_1d(mean.squeeze()), covariance) |
henrymoss
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failurebefore committing.Description
Tighten up the underlying codebase by removing aspects of the code that are either incongruent with the entire API, or introduce too much boilerplate code for their returned utility. The code being removed is deeply woven into the source code, so adding deprecations is not possible.
Notes:
strict=Trueargument has been added to allzipcalls to make Ruff compliant with Python 3.10 standards. See B905Issue Number: N/A