Simplified regex match storing code #398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than first writing matches to a temporary variable, we write them directly to the class member variable. This eliminates the temporary
$matches
variable and also the temporary$result
variable.Note that we also eliminated the
if
statement which is intentional because it is this author's belief that it is incorrect for two reasons:$matches
are saved; if the method is called then$matches
should always be updated rather than persist the result from a previous call.