Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test file name #403

Merged
merged 3 commits into from Aug 25, 2020
Merged

Fixed test file name #403

merged 3 commits into from Aug 25, 2020

Conversation

Bilge
Copy link
Contributor

@Bilge Bilge commented Aug 22, 2020

  • Fixed test file name. PHPUnit tests should end with Test verbatim. The class name already did, so the file name was updated to match. This fixes an issue where targeting the tests directory, e.g. vendor/bin/phpunit tests did not find any tests to run.
  • Removed test bootstrap because it didn't do anything.
  • Added final to indicate inheritance of test case is not intended.
  • Changed visibility of member variable to private because class is final.
  • Changed visibility of overridden setUp method to match parent.
  • Changed Travis to use Composer invocation of test suite, since such a script is defined for this purpose already but not currently used. Doesn't work on PHP < 5.6.
  • Fixed code coverage generation.

This is just a first pass to fix the major test issues. More to follow if this PR is accepted.

Removed test bootstrap.
Causes builds to time out on PHP < 5.6.
@Bilge Bilge force-pushed the tests branch 2 times, most recently from 287e565 to 1fd6a30 Compare August 23, 2020 09:16
@JayBizzle
Copy link
Owner

Looks good!

@JayBizzle JayBizzle merged commit a07ca2d into JayBizzle:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants