Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: Add -fno-common to CFLAGS #233

Closed
wants to merge 1 commit into from

Conversation

candrews
Copy link

-fno-common will be set by default in GCC 10, see https://gcc.gnu.org/PR85678

Therefore, cpuminer-opt should test with that configuration to be ready for this change.

See #232

-fno-common will be set by default in GCC 10, see https://gcc.gnu.org/PR85678

Therefore, cpuminer-opt should test with that configuration to be ready for this change.

See JayDDee#232
@JayDDee
Copy link
Owner

JayDDee commented Jan 28, 2020

Another surprise, I wasn't aware Travis worked, I've never touched it since I forked.
I'll be fixing the violators so I won't need this workaround.

@JayDDee
Copy link
Owner

JayDDee commented Jan 30, 2020

Well, it doesn't work because Ihave no travis.yml file. Furthermore cpuminer-opt-3.11.8 rewrote
the offending code making the flag unnesessary. Closing.

@JayDDee JayDDee closed this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants