Add port to original Xbox using nxdk #1

JayFoxRox · 2020-04-03T22:43:49Z

Rudimentary spite-port that was created after ModernVintageGamer announced that he'd be releasing HODE for Xbox built using the proprietary Xbox Development Kit that is (typically) illegally obtained.

In response, I challenged myself to create a port (within an hour or so) using the open-source and legally obtainable nxdk toolchain. In the end, it took about 3 hours (including some fine-tuning).

The port loads game files from the DVD drive / D: folder (that's typically the folder where the default.xbe is).
The port contains some native Windows support, too (intended to support more Windows toolchains).
The button layout tries to recreate what was documented in some Playstation guide.
The game stores savegames in E:/UDATA/hode (in case you want to move savegames around manually).

Requires XboxDev/nxdk-sdl#20.

(Last tested on XboxDev/nxdk@d42400d with XboxDev/nxdk-sdl@0ae8796)

JayFoxRox · 2020-04-03T23:18:02Z

fs_win32.cpp

+#ifndef NXDK
+#include <stdlib.h>
+#else
+#define _MAX_PATH 200 //FIXME: Get real value for Xbox?


FIXME: This should be fixed upstream so we no longer need this different code-path

JayFoxRox · 2020-04-03T23:20:00Z

main.cpp

+
+void __cdecl operator delete(void *ptr) {
+	free(ptr);
+}


FIXME: new and delete should be from libcxx. Why don't we seem to have those?

Requires NXDK_CXX = y in Makefile. Not fixed yet.

JayFoxRox · 2020-04-03T23:20:15Z

main.cpp

+
+extern "C" {
+	extern uint8_t* _fb;
+}


FIXME: This works around a bug in nxdk video.h

JayFoxRox · 2020-04-03T23:20:24Z

main.cpp

+	memset(_fb, 0x00, fb_size);
+#define _PCRTC_START				0xFD600800
+	*(unsigned int*)(_PCRTC_START) = (unsigned int)_fb & 0x03FFFFFF;
+#endif


FIXME: This works around a bug in nxdk video.h

JayFoxRox · 2020-04-03T23:21:11Z

main.cpp

+#if defined(NXDK)
+	// Set display mode (16bpp to save memory)
+	//FIXME: Temporarily switched to 32bpp, as I got weird issues at 16bpp
+	XVideoSetMode(640, 480, 32, REFRESH_DEFAULT);


FIXME: Check wether game works on all refresh rates? Also switch to 16bpp mode?

JayFoxRox · 2020-04-03T23:21:53Z

main.cpp

 		} else if (strcmp(name, "gamma") == 0) {
 			g_system->setGamma(atof(value));
+#endif


FIXME: nxdk lacks atof

JayFoxRox · 2020-04-04T03:24:20Z

Makefile.nxdk

+	resource.cpp screenshot.cpp sound.cpp staticres.cpp system_sdl2.cpp \
+	util.cpp video.cpp
+
+SCALERS := scaler_nearest.cpp #FIXME: scaler_xbr.cpp is broken in nxdk


FIXME: The XBR scaler is broken; the linker will throw a warning and the result XBE will not launch. I assume cxbe can't handle files with dllexports?

JayFoxRox · 2020-04-04T03:39:10Z

I got a crash / hang after about 20 minutes. I'm not sure where or how it crashed.
We previously had known that my SDL audio code isn't the most stable, so that might be why?

Could also be running out of memory or something? This needs more stress testing.

JayFoxRox · 2020-04-04T03:47:50Z

I had a crash (or assert?) during the loadscreen. I previously got such crashes when my strcasecmp was wrong. The assert back then was this one https://github.com/JayFoxRox/hode/blob/master/resource.h#L523 because it opens the wrong file. Someone should valgrind my new functions, too.

tuxuser · 2020-04-10T17:23:54Z

Suggestion for fs_win32.cpp

 	char filePath[_MAX_PATH];
 	WIN32_FIND_DATAA de;
 	snprintf(filePath, sizeof(filePath), "%s\\*", dir);
 	HANDLE d = FindFirstFileA(filePath, &de);
 	if (d != INVALID_HANDLE_VALUE) {
 		BOOL found = TRUE;
-		while (1) {
-			if (de.cFileName[0] == '.') {
+		do
+		{
+			if (de.cFileName[0] == '.')
+			{
 				continue;
 			}
 			snprintf(filePath, sizeof(filePath), "%s\\%s", dir, de.cFileName);
 			if (de.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) {
 				listFiles(filePath);
-			} else if (matchGameData(filePath)) {
-				addFilePath(filePath);
 			}
-			if(!FindNextFileA(d, &de)) {
-				break;
+			else if (matchGameData(filePath)) {
+				addFilePath(filePath);
 			}
-		}
-		CloseHandle(d);
+		} while (FindNextFileA(d, &de) != 0);
+		FindClose(d);
 	}
 }

Previously with

        HANDLE d = FindFirstFileA(filePath, &de);
 	if (d != INVALID_HANDLE_VALUE) {
 		BOOL found = TRUE;
		while (1) {
			if (de.cFileName[0] == '.') {
 				continue;
 			}
                        // add files and skip to next one with
                        // FindNextFile
                 }

when it encountered a filename starting with . it would have ended in an infinite loop cause FindNextFile never got called.

JayFoxRox · 2020-04-11T00:30:23Z

Thanks for the report. I'll eventually fix it (if nobody else does it before this file hits upstream - which hopefully happens). For now I have too many other projects to care for HODE. Our Xbox toolchain also needs bugs fixed before this is worth more of my time.

I believe your code still wouldn't run the statement at the end of the while loop?
I'm not sure about semantics in C, but would it really do that step for a continue?

I'm more tempted to rewrite this function with more nesting or a goto.

JayFoxRox · 2020-04-11T00:32:26Z

Demon27248 wrote:
For the record, audio was present. By "broken", I meant it was out of sync with what was happening on screen (and there might have been sound effects missing but I wasn't sure). https://files.catbox.moe/j3jsqb.mp4

I'm confused about which revisions you used. Might have had a bad combination of submodules.

Video delay

For now, I assume that the video-capture device added the delay. It's highly unusual to have video lagging behind audio. The game has no room in memory to buffer video frames, and audio is only started when the animation also plays. If there was a latency issue we'd expect the audio to be lagging behind the video.

Crash near end

The early crash at the end of the video is unfortunate. I never had a crash this early. It might be something related to specific Xbox revisions, temperature, signal noise, uninitialized memory or something.

JayFoxRox · 2020-04-13T01:07:46Z

fs_win32.cpp

+				break;
+			}
+		}
+		CloseHandle(d);


This is a bug; from MSDN:

When the search handle is no longer needed, close it by using the FindClose function, not CloseHandle.

CC @tuxuser

JayFoxRox commented Apr 3, 2020

View reviewed changes

main.cpp

extern "C" {

extern uint8_t* _fb;

}

Copy link

Owner Author

JayFoxRox Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: This works around a bug in nxdk video.h

JayFoxRox commented Apr 3, 2020

View reviewed changes

main.cpp

} else if (strcmp(name, "gamma") == 0) {

g_system->setGamma(atof(value));

#endif

Copy link

Owner Author

JayFoxRox Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: nxdk lacks atof

JayFoxRox force-pushed the nxdk branch 5 times, most recently from 3e7f3ca to 6c39619 Compare April 4, 2020 03:06

JayFoxRox commented Apr 4, 2020

View reviewed changes

JayFoxRox mentioned this pull request Apr 4, 2020

audio: Implement Xbox driver using OpenXDK XAudio XboxDev/nxdk-sdl#20

Merged

JayFoxRox added 2 commits April 4, 2020 05:56

Add port for original Xbox using nxdk

39101d4

Recreate Playstation button layout for original Xbox

ab70deb

JayFoxRox force-pushed the nxdk branch from 6c39619 to ab70deb Compare April 4, 2020 03:59

This was referenced Apr 10, 2020

[Port] WinRT / UWP - Xbox One and Windows 10 usineur/hode#6

Closed

SDL Audio driver is unstable and potentially hangs or crashes XboxDev/nxdk-sdl#26

Open

JayFoxRox commented Apr 13, 2020

View reviewed changes

JayFoxRox mentioned this pull request Apr 25, 2020

nxdk creates invalid XBE under some circumstances XboxDev/nxdk#324

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add port to original Xbox using nxdk #1

Add port to original Xbox using nxdk #1

JayFoxRox commented Apr 3, 2020 •

edited

JayFoxRox Apr 3, 2020

JayFoxRox Apr 3, 2020

JayFoxRox Apr 5, 2020

JayFoxRox Apr 3, 2020

JayFoxRox Apr 3, 2020

JayFoxRox Apr 3, 2020

JayFoxRox Apr 3, 2020

JayFoxRox Apr 4, 2020

JayFoxRox commented Apr 4, 2020

JayFoxRox commented Apr 4, 2020 •

edited

tuxuser commented Apr 10, 2020

JayFoxRox commented Apr 11, 2020

JayFoxRox commented Apr 11, 2020

JayFoxRox Apr 13, 2020

Add port to original Xbox using nxdk #1

Are you sure you want to change the base?

Add port to original Xbox using nxdk #1

Conversation

JayFoxRox commented Apr 3, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayFoxRox commented Apr 4, 2020

JayFoxRox commented Apr 4, 2020 • edited

tuxuser commented Apr 10, 2020

JayFoxRox commented Apr 11, 2020

JayFoxRox commented Apr 11, 2020

Choose a reason for hiding this comment

JayFoxRox commented Apr 3, 2020 •

edited

JayFoxRox commented Apr 4, 2020 •

edited