WIP: sketch out on-disk hextree #179
JayKickliterAnnotations
2 errors and 11 warnings
|
name `DPTR` contains a capitalized acronym:
src/disktree/mod.rs#L13
error: name `DPTR` contains a capitalized acronym
--> src/disktree/mod.rs:13:6
|
13 | type DPTR = [u8; 5];
| ^^^^ help: consider making the acronym lowercase, except the initial letter: `Dptr`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
= note: `-D clippy::upper-case-acronyms` implied by `-D clippy::all`
|
|
build
Clippy had exited with the 101 exit code
|
|
associated items `fixed`, `prefixed`, `to_writer`, and `from_reader` are never used:
src/disktree/valsize.rs#L22
warning: associated items `fixed`, `prefixed`, `to_writer`, and `from_reader` are never used
--> src/disktree/valsize.rs:22:19
|
21 | impl ValSizeV0 {
| -------------- associated items in this implementation
22 | pub(crate) fn fixed(sz: u32) -> Self {
| ^^^^^
...
26 | pub(crate) fn prefixed(bytes: u32) -> DiskTreeResult<Self> {
| ^^^^^^^^
...
34 | pub(crate) fn to_writer(&self, wtr: &mut impl Write) -> DiskTreeResult {
| ^^^^^^^^^
...
48 | pub(crate) fn from_reader(rdr: &mut impl Read) -> DiskTreeResult<Self> {
| ^^^^^^^^^^^
|
|
enum `ValSizeV0` is never used:
src/disktree/valsize.rs#L5
warning: enum `ValSizeV0` is never used
--> src/disktree/valsize.rs:5:17
|
5 | pub(crate) enum ValSizeV0 {
| ^^^^^^^^^
|
|
function `write_dptr` is never used:
src/disktree/mod.rs#L74
warning: function `write_dptr` is never used
--> src/disktree/mod.rs:74:15
|
74 | pub(crate) fn write_dptr(dst: &mut impl Write, dptr: u64) -> DiskTreeResult {
| ^^^^^^^^^^
|
|
function `read_dptr` is never used:
src/disktree/mod.rs#L67
warning: function `read_dptr` is never used
--> src/disktree/mod.rs:67:15
|
67 | pub(crate) fn read_dptr(src: &mut impl Read) -> DiskTreeResult<u64> {
| ^^^^^^^^^
|
|
method `position` is never used:
src/disktree/mod.rs#L61
warning: method `position` is never used
--> src/disktree/mod.rs:61:8
|
59 | impl<R: Read + Seek> DiskTree<R> {
| -------------------------------- method in this implementation
60 | // Returns our current position in the file.
61 | fn position(&mut self) -> DiskTreeResult<u64> {
| ^^^^^^^^
|
|
method `read_dptr` is never used:
src/disktree/mod.rs#L45
warning: method `read_dptr` is never used
--> src/disktree/mod.rs:45:8
|
32 | impl<R: Read> DiskTree<R> {
| ------------------------- method in this implementation
...
45 | fn read_dptr(&mut self) -> DiskTreeResult<u64> {
| ^^^^^^^^^
|
|
constant `DPTR_MAX` is never used:
src/disktree/mod.rs#L15
warning: constant `DPTR_MAX` is never used
--> src/disktree/mod.rs:15:7
|
15 | const DPTR_MAX: u64 = 2_u64.pow(std::mem::size_of::<DPTR>() as u32 * 8) - 1;
| ^^^^^^^^
|
|
constant `DPTR_DEFAULT` is never used:
src/disktree/mod.rs#L14
warning: constant `DPTR_DEFAULT` is never used
--> src/disktree/mod.rs:14:7
|
14 | const DPTR_DEFAULT: DPTR = [0_u8; 5];
| ^^^^^^^^^^^^
|
|
type alias `DPTR` is never used:
src/disktree/mod.rs#L13
warning: type alias `DPTR` is never used
--> src/disktree/mod.rs:13:6
|
13 | type DPTR = [u8; 5];
| ^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
src/disktree/valsize.rs#L50
warning: variable does not need to be mutable
--> src/disktree/valsize.rs:50:13
|
50 | let mut sz_buf = [0; 4];
| ----^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|