impl TryFrom<i64> for Cell #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
approved these changes
Apr 22, 2024
michaeldjeffrey
added a commit
to helium/oracles
that referenced
this pull request
Apr 23, 2024
Update includes an implementation of TryFrom<i64> for Cell. This allows adding `#[sqlx(try_from = "i64")]` to struct fields of `hextree::Cell`. JayKickliter/HexTree#45
michaeldjeffrey
added a commit
to helium/oracles
that referenced
this pull request
Apr 26, 2024
Update includes an implementation of TryFrom<i64> for Cell. This allows adding `#[sqlx(try_from = "i64")]` to struct fields of `hextree::Cell`. JayKickliter/HexTree#45
michaeldjeffrey
added a commit
to helium/oracles
that referenced
this pull request
Apr 26, 2024
Update includes an implementation of TryFrom<i64> for Cell. This allows adding `#[sqlx(try_from = "i64")]` to struct fields of `hextree::Cell`. JayKickliter/HexTree#45
michaeldjeffrey
added a commit
to helium/oracles
that referenced
this pull request
Apr 26, 2024
* Update hextree dependency Update includes an implementation of TryFrom<i64> for Cell. This allows adding `#[sqlx(try_from = "i64")]` to struct fields of `hextree::Cell`. JayKickliter/HexTree#45 * Use `hextree::Cell` for BoostedHex and HexCoverage Got some advice from Jay to only use a `h3o::CellIndex` when you need to convert to/from a LatLng. So we went with `hextree::Cell` for the type. `hextree::Cell` is a loose wrapper around a u64. Parsing the value as early as possible tightens the gaurantee that we can make valid types that need use `Cell`s. It is also an attempt to remove discrepancies where some types carry a `i64` hex straight from a database, and other types carry a `u64` that were converted out of a database, even though they're goal is the same. (see previous commit where `#[sqlx(try_from = "i64")]` was enabled by the update to hextree).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michaeldjeffrey