Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change iquery to qset and qget #186

Closed
2 of 3 tasks
Jaymon opened this issue Apr 5, 2024 · 0 comments
Closed
2 of 3 tasks

Change iquery to qset and qget #186

Jaymon opened this issue Apr 5, 2024 · 0 comments

Comments

@Jaymon
Copy link
Owner

Jaymon commented Apr 5, 2024

Where qset is called for a setting query (insert, update) and qget is called for a read query (select).

I also think it would be better for these methods to take the QueryField instance instead of the Query instance.

These are the things that would need to be done:

  • QueryField needs to know in what context is being used for, Query.set should make the query field call qset while all the other methods should call qget (eg, eq_* and select_*)
  • Modify QueryField.iquery to call the appropriate method
  • Change the query methods to accept the QueryField instance instead of Query, this shouldn't break anything since I don't think I've ever actually used the method for anything.
@Jaymon Jaymon closed this as completed in a1cb9df Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant