Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change read duration total to include all history #1415

Merged
merged 4 commits into from
Nov 11, 2022

Conversation

nzoba
Copy link

@nzoba nzoba commented Sep 5, 2022

Just saw that the total read duration doesn't include all history, just the manga in library, so I changed that

And some visual changes:

  • tweaked a bit the general stats in case there is a language with long words and to avoid setting the number of lines
  • reorganized the stats to have more homogeneous description lines (not sure which is better between vertical centered or top, let me know if you have a preference)
  • added tooltips for read duration and mean score
  • converted the link to stats details to a button
  • fixed the status distribution wrapping when the text + value are too long (wrap the description text instead of value now)

Stats screen

Also tweaked the details stats order to put the read duration higher

@Jays2Kings
Copy link
Owner

I'll likely just update the wording on "Mean score" but this works for now

@Jays2Kings Jays2Kings merged commit 7ad3f2b into Jays2Kings:master Nov 11, 2022
@nzoba nzoba deleted the all-history-read-duration-j2k branch November 14, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants