Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoAP: Fix recovering from incorrect IPv6 address at start #259

Merged
merged 1 commit into from Dec 1, 2022

Conversation

Jc2k
Copy link
Owner

@Jc2k Jc2k commented Dec 1, 2022

We only set the updated address when there was an encryption context. That meant we couldn't fix the IP if it was wrong at startup.

Fixes: https://community.home-assistant.io/t/homekit-accessory-protocol-hap-over-coap-udp-was-nanoleaf-essentials-bulb-via-thread-coap/335167/311?u=jc2k.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 66.83% // Head: 66.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d2716ae) compared to base (14457a8).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   66.83%   66.84%           
=======================================
  Files          71       71           
  Lines        6664     6666    +2     
=======================================
+ Hits         4454     4456    +2     
  Misses       2210     2210           
Flag Coverage Δ
unittests 66.84% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohomekit/controller/coap/connection.py 29.92% <ø> (+0.15%) ⬆️
aiohomekit/controller/coap/pairing.py 32.08% <50.00%> (+0.02%) ⬆️
aiohomekit/controller/ip/pairing.py 78.62% <100.00%> (+0.08%) ⬆️
aiohomekit/controller/ble/client.py 33.33% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Jc2k Jc2k merged commit 1e4d856 into main Dec 1, 2022
@Jc2k Jc2k deleted the thread_wrong_addr_at_start branch December 1, 2022 07:16
@Jc2k
Copy link
Owner Author

Jc2k commented Dec 1, 2022

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants