-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates README network section with better example #41
Conversation
I took a crack at fixing the CI errors. Notably, I bumped the minimum Python version to 3.7.0 since 3.6 went EOL this year anyways. |
Thanks so much! Wasn't sure when I was gonna find the time for that 🤣 good call on 3.6. |
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 93.05% 93.39% +0.33%
==========================================
Files 18 18
Lines 547 560 +13
==========================================
+ Hits 509 523 +14
+ Misses 38 37 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I think we want to have pytest run in the root dir so that pytest-markdown runs for the README. Or maybe specifically pass the readme to pytest. |
Ah, that makes more sense. I couldn't figure out why it was hitting the README, didn't realize there was a plugin that was grabbing it. |
I'm really bad at testing my documentation so I thought i better run it as tests 😆 |
Well turns out I'm just as bad since I didn't modify the imports on the example I expanded upon :) I think everything should pass now and I reverted |
Awesome! Thank you so much for sorting that out 😄 |
No worries. If you can manage a release soon with the package updates that would be awesome :) I'm getting dependabot alerts on the |
I have done a release that unpins the docker version (3.1.3). But I don't think that will stop your alert, unfortunately: |
Kinda looks like the official python docker client is unmaintained |
Addresses #40 by making a small addendum in the network section example to show how to use the network name when creating a container.