Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Drones (PX4 + AS2) ILauncher #73

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

pawanw17
Copy link
Collaborator

No description provided.

@pariaspe pariaspe self-requested a review August 16, 2023 14:50
Copy link
Contributor

@pariaspe pariaspe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Does it make sense to launch together px4 and as2?

@pawanw17 pawanw17 changed the title Aerostack2 ILauncher ROS2 Drones () ILauncher Aug 17, 2023
@pawanw17 pawanw17 changed the title ROS2 Drones () ILauncher ROS2 Drones (PX4 + AS2) ILauncher Aug 17, 2023
@pariaspe pariaspe merged commit 615834c into JdeRobot:main Aug 17, 2023
This was referenced Aug 17, 2023
from src.manager.manager.launcher.launcher_interface import ILauncher, LauncherException
from src.manager.manager.docker_thread.docker_thread import DockerThread
from typing import List, Any
import time
Copy link
Collaborator Author

@pawanw17 pawanw17 Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pariaspe this import needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants