This repository has been archived by the owner on Feb 21, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interfaces step 2: cleanup due it is working without any problem
Completes #237
dummy_main.c
approach for headers trickBreaks target install convection
move slice files from include/jderobot/slice to share/jderobot/slice
This is the way to go because slice files are auxiliary files and do not interact with cxx compilers. So there was two options:
(2) was chosen because (1) is dirty with the current policy for headers.
Advice for visualHFSM
@reysam93, I must change a little piece of visualHFSM. Therefore this PR should be merged if and only if you approve it.
By the way, you should change this call because hardcored paths are not recommended.
Recommendation:
jump to
system("./getinterfaces.sh)
and put static paths at sh file. Why? because change paths can be done at runtime and do not require rebuild.Eventually this can even jump to
system("getinterfaces.sh)
and patch PATH inside cpp to add '.' directory. Therefore, /usr/local/bin/getinterfaces.sh (if it is planned to be installed) will be callable and allow execute visualHFSM out of the box.PS: I suspect that @jmplaza must also approve it.