Skip to content
This repository has been archived by the owner on Feb 21, 2021. It is now read-only.

Interfaces' cmake cleanup (step 2) #280

Closed
wants to merge 4 commits into from

Conversation

varhub
Copy link
Contributor

@varhub varhub commented Dec 23, 2015

Interfaces step 2: cleanup due it is working without any problem

Completes #237

Breaks target install convection

move slice files from include/jderobot/slice to share/jderobot/slice
This is the way to go because slice files are auxiliary files and do not interact with cxx compilers. So there was two options:

  1. install belong generated headers to ensure C++ coalescence
  2. remove from include because current path do not fit Linux's include/ policy.

(2) was chosen because (1) is dirty with the current policy for headers.

Advice for visualHFSM

@reysam93, I must change a little piece of visualHFSM. Therefore this PR should be merged if and only if you approve it.
By the way, you should change this call because hardcored paths are not recommended.
Recommendation:
jump to system("./getinterfaces.sh) and put static paths at sh file. Why? because change paths can be done at runtime and do not require rebuild.
Eventually this can even jump to system("getinterfaces.sh) and patch PATH inside cpp to add '.' directory. Therefore, /usr/local/bin/getinterfaces.sh (if it is planned to be installed) will be callable and allow execute visualHFSM out of the box.

PS: I suspect that @jmplaza must also approve it.

slice files (*.ice) are not normal headers neither C++ headers, so these should not be placed at include.
otherways, they MUST be placed in same tree as generated files to ensure C++ coalescence
@fqez
Copy link
Member

fqez commented Jan 4, 2016

Ok then. I'm not touching this until both @jmplaza and @reysam93 confirm this can be merged.

@varhub varhub changed the title Interfaces step 2 Interfaces' cmake (step 2) Jan 9, 2016
@varhub varhub changed the title Interfaces' cmake (step 2) Interfaces' cmake cleanup (step 2) Jan 9, 2016
@fqez fqez added the delayed label Mar 3, 2016
@fqez
Copy link
Member

fqez commented Jul 27, 2017

I close this PR because is so ancient. If you want to return on developing this particular issue, let me know and I will reopen it!

Cheers!

@fqez fqez closed this Jul 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants