Skip to content

Commit

Permalink
refactor(forms): deprecate unwanted control events aliases
Browse files Browse the repository at this point in the history
This commit deprecates the aliases for the control events to ease the changes in G3
A follow-up commit will remove those deprecated entries.
  • Loading branch information
JeanMeche committed May 8, 2024
1 parent 1872fcd commit 57fe249
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 6 deletions.
18 changes: 15 additions & 3 deletions goldens/public-api/forms/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -786,14 +786,18 @@ export class PatternValidator extends AbstractValidatorDirective {
}

// @public
export class PristineEvent extends ControlEvent {
export class PristineChangeEvent extends ControlEvent {
constructor(pristine: boolean, source: AbstractControl);
// (undocumented)
readonly pristine: boolean;
// (undocumented)
readonly source: AbstractControl;
}

// @public @deprecated (undocumented)
export class PristineEvent extends PristineChangeEvent {
}

// @public
export class RadioControlValueAccessor extends BuiltInControlValueAccessor implements ControlValueAccessor, OnDestroy, OnInit {
constructor(renderer: Renderer2, elementRef: ElementRef, _registry: RadioControlRegistry, _injector: Injector);
Expand Down Expand Up @@ -880,23 +884,31 @@ export class SelectMultipleControlValueAccessor extends BuiltInControlValueAcces
export type SetDisabledStateOption = 'whenDisabledForLegacyCode' | 'always';

// @public
export class StatusEvent extends ControlEvent {
export class StatusChangeEvent extends ControlEvent {
constructor(status: FormControlStatus, source: AbstractControl);
// (undocumented)
readonly source: AbstractControl;
// (undocumented)
readonly status: FormControlStatus;
}

// @public @deprecated (undocumented)
export class StatusEvent extends StatusChangeEvent {
}

// @public
export class TouchedEvent extends ControlEvent {
export class TouchedChangeEvent extends ControlEvent {
constructor(touched: boolean, source: AbstractControl);
// (undocumented)
readonly source: AbstractControl;
// (undocumented)
readonly touched: boolean;
}

// @public @deprecated (undocumented)
export class TouchedEvent extends TouchedChangeEvent {
}

// @public
export type UntypedFormArray = FormArray<any>;

Expand Down
9 changes: 6 additions & 3 deletions packages/forms/src/forms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,12 @@ export {
AbstractControlOptions,
ControlEvent,
FormControlStatus,
PristineChangeEvent as PristineEvent,
StatusChangeEvent as StatusEvent,
TouchedChangeEvent as TouchedEvent,
PristineEvent,
StatusEvent,
TouchedEvent,
PristineChangeEvent,
StatusChangeEvent,
TouchedChangeEvent,
ValueChangeEvent,
ɵCoerceStrArrToNumArr,
ɵGetProperty,
Expand Down
15 changes: 15 additions & 0 deletions packages/forms/src/model/abstract_model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@ export class PristineChangeEvent extends ControlEvent {
}
}

/**
* @deprecated use `PristineChangeEvent` symbol instead.
*/
export class PristineEvent extends PristineChangeEvent {}

/**
* Event fired when the control's touched status changes (touched <=> untouched).
*
Expand All @@ -130,6 +135,11 @@ export class TouchedChangeEvent extends ControlEvent {
}
}

/**
* @deprecated use `TouchedChangeEvent` symbol instead.
*/
export class TouchedEvent extends TouchedChangeEvent {}

/**
* Event fired when the control's status changes.
*
Expand All @@ -144,6 +154,11 @@ export class StatusChangeEvent extends ControlEvent {
}
}

/**
* @deprecated use `StatusChangeEvent` symbol instead.
*/
export class StatusEvent extends StatusChangeEvent {}

/**
* Gets validators from either an options object or given validators.
*/
Expand Down

0 comments on commit 57fe249

Please sign in to comment.