Make chruby-fish Fish 2.2.0 compatible #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMertz
added a commit
that referenced
this pull request
Jan 19, 2016
Make chruby-fish Fish 2.2.0 compatible
|
👍 Thanks! |
| set dir (string trim -r -c/ "$dir") | ||
| set ruby (string split -m1 -r / $dir | tail -n1) | ||
| set dir (echo "$dir" | sed -e 's|/$||') | ||
| set ruby (echo "$dir" | awk -F/ '{print $NF}') |
There was a problem hiding this comment.
@JeanMertz My only concern with this approach is the availability of sed and awk, as well as differences between distributions (e.g. gawk and mawk). I think cut would be a better solution here, but I cannot 100% guarantee. Thoughts?
There was a problem hiding this comment.
To my knowledge, all (major) distributions of sed and awk support the respective flags used above. Using cut instead of sed would require something like rev | cut -c2- | rev for example, which might perform slower.
Either way, good point, and something to watch out for. If it ever becomes a problem, we can switch this to something else (until Fish 2.3 is released, and we can switch back to using string, that is).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dependency on string builtin.
closes #25