You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm having this specific problem using classNames with webpackdevtool option set to eval. It only happens on Chrome and when the console is not open. The issue is calling classNames inside the classNames function with the 'use strict' statement inside the function (https://github.com/JedWatson/classnames/blob/master/index.js#L22), this will cause a ReferenceError.
I think we could take use strict out if it's causing trouble, or @daviferreira am happy to review your wrapper too if that solves the problem.
From what I understand, modern javascript engines are able to optimise certain code paths if they know a function is in strict mode, this may or may not be a major issue / benefit for classNames - unfortunately I'm not familiar enough with the inner workings to say for sure...
I'm having this specific problem using
classNames
withwebpack
devtool
option set toeval
. It only happens on Chrome and when the console is not open. The issue is callingclassNames
inside theclassNames
function with the'use strict'
statement inside the function (https://github.com/JedWatson/classnames/blob/master/index.js#L22), this will cause aReferenceError
.See:
webpack/webpack#417
Explanation:
ftlabs/fastclick#270
I would be happy to submit a PR with a umd wrapper if you guys are ok with it :)
Thanks for the great lib!
The text was updated successfully, but these errors were encountered: