This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Wrap whole lib in umd wrapper and remove redundant 'use strict' #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (function (root, factory) { | ||
| if (typeof exports === 'object') { | ||
| // CommonJS | ||
| module.exports = factory(); |
There was a problem hiding this comment.
(Irritatingly) I think this should be:-
var FastClick = factory();
module.exports = FastClick.attach;
module.exports.FastClick = FastClick;Otherwise we break the previous API expected by common js :-/
jhnns
added a commit
to jhnns/fastclick
that referenced
this pull request
Aug 21, 2014
It fixes a problem when fastclick is used with a bundler like browserify or webpack which use eval() for source urls. According to the documentation on eval() in strict mode "strict" code can only access variables defined by eval() in the same scope. Thus accessing FastClick or deviceIsAndroid inside of a function (which is preceded by 'use strict') triggers a ReferenceError. ftlabs#270
jhnns
added a commit
to jhnns/fastclick
that referenced
this pull request
Aug 21, 2014
It fixes a problem when fastclick is used with a bundler like browserify or webpack which use eval() for source urls. According to the documentation on eval() in strict mode "strict" code can only access variables defined by eval() in the same scope. Thus accessing FastClick or deviceIsAndroid inside of a function (which is preceded by 'use strict') triggers a ReferenceError. ftlabs#270
jhnns
added a commit
to jhnns/fastclick
that referenced
this pull request
Aug 21, 2014
It fixes a problem when fastclick is used with a bundler like browserify or webpack which use eval() for source urls. According to the documentation on eval() in strict mode "strict" code can only access variables defined by eval() in the same scope. Thus accessing FastClick or deviceIsAndroid inside of a function (which is preceded by 'use strict') triggers a ReferenceError. ftlabs#270
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request wraps the whole library in a umd wrapper.
It fixes a problem when fastclick is used with a bundler like browserify or webpack which use
eval()for source urls.According to the documentation on
eval()in strict mode "strict" code can only access variables defined byeval()in the same scope. Thus accessingFastClickordeviceIsAndroidinside of a function (which is preceded by'use strict';) triggers aReferenceError.Hence fastclick doesn't work with browserify or webpack in dev-mode.
The diff looks horrible because I needed to indent the whole lib. Actually I've done these changes:
This also fixes #231