Eliminate React version mismatch pitfall #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test plan:
Looks great. |
|
Great, thanks @steveluscher! |
JedWatson
added a commit
that referenced
this pull request
Sep 1, 2015
Eliminate React version mismatch pitfall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say that I'm using React 0.14 in my app. Since this component specifies 0.13 in its
package.jsonit will be built with a different version/instance of React than its parent. This will lead to puzzling errors, like #7.This PR moves React to peerDependencies, and makes it compatible with every version of 0.13 and 0.14.