protect against reading removeEventListener from el if null (#4213)

* protect against reading removeEventListener from el if null * Added changeset Co-authored-by: Eythor Gisli Thorsteinsson <eythort@menandmice.com> Co-authored-by: Jed Watson <jed.watson@me.com> Co-authored-by: Nathan Bierema <nbierema@gmail.com>
JedWatson · Dec 12, 2020 · d1e660c · d1e660c
1 parent a0133f1
commit d1e660c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changeset/lemon-boats-cover.md b/.changeset/lemon-boats-cover.md
@@ -0,0 +1,5 @@
+---
+"react-select": patch
+---
+
+Added a guard to the `ScrollCaptor` component to check that `el` exists before calling `removeEventListener`, fixes intermittent errors
diff --git a/packages/react-select/src/internal/ScrollCaptor.js b/packages/react-select/src/internal/ScrollCaptor.js
@@ -40,6 +40,8 @@ class ScrollCaptor extends Component<CaptorProps> {
     }
   }
   stopListening(el: HTMLElement) {
+    if (!el) return;
+
     // all the if statements are to appease Flow 😢
     if (typeof el.removeEventListener === 'function') {
       el.removeEventListener('wheel', this.onWheel, false);