Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a nvmrc file and adding coverage to eslintignore #1137

Merged
merged 1 commit into from
Oct 22, 2017

Conversation

uxtx
Copy link
Contributor

@uxtx uxtx commented Aug 2, 2016

I've taken to using an nvmrc file in my node projects to peg the node version, and thought it might be helpful here. This allows autoswitching to be much easier, especially when used in conjunction with this plugin https://github.com/creationix/nvm#zsh

I also adding coverage to exclusion in eslintignore - if you happened to run npm run cover prior to npm test, you'd get linting errors from the coverage report.

@uxtx
Copy link
Contributor Author

uxtx commented Aug 2, 2016

ugh. it looks like there's an issue with tests running in the latest version of react (15.3.0 was just released 4 days ago and now tests are failing on all branches. I just checked using ~15.2.0 and tests pass.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.714% when pulling 753a4f6 on uxtx:nvmrc into e19bce3 on JedWatson:master.

@uxtx
Copy link
Contributor Author

uxtx commented Aug 4, 2016

for the time being, i'm locking version to 15.2. Going to look at why simulate events are failing in a separate branch. looks like this isn't necessary anymore, (thanks @mikehazell)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.714% when pulling 0076fdf on uxtx:nvmrc into e19bce3 on JedWatson:master.

- also adding coverage to exclusion in eslintignore
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.892% when pulling 4822d43 on uxtx:nvmrc into 4714955 on JedWatson:master.

@uxtx uxtx changed the title adding a nvmrc file adding a nvmrc file and adding coverage to eslintignore Sep 5, 2016
@gwyneplaine
Copy link
Collaborator

thanks for this @uxtx, merged

@gwyneplaine gwyneplaine merged commit f65a2f4 into JedWatson:master Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants